Fix Pipedrive set custom field string mapping#686
Open
srl-git wants to merge 1 commit into
Open
Conversation
Collaborator
|
It is tested once and works as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
Short description
Fixes Pipedrive V1 custom field mapping for
setfields returned as comma-separated strings.Previously, values like
"62,63,65"were treated as generic iterables, so the mapper iterated over each character and produced values like"6","2",",", etc. This change normalizes stringsetvalues into option IDs before mapping them to readable option labels.Added a regression test covering comma-separated Pipedrive
setcustom field values.Related Issues
No related issue. This was found while debugging Pipedrive custom field loading locally.